lkml.org 
[lkml]   [2015]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
On 07/27/15 at 11:31am, Yinghai Lu wrote:
> >> #else
> >> static void __init reserve_crashkernel(void)
>
> No, you can not move the calling position for reserve_crashkernel_low().
>
> old sequence:
>
> memblock_find_in_range for high
> memblock_reserve for high
> memblock_find_in_range for low
> memblock_reserve for low
>
> now you change to:
> memblock_find_in_range for high
> memblock_find_in_range for low
> memblock_reserve for low
> memblock_reserve for high
>
> during memblock_reserve, we would double the memblock reserve array.
> So there is possibility that new membock reserve array is overlapped with
> range for crashdump high.
>
> so you should keep the old sequence, and if reserve_crashkernel_low fail,
> just call memblock_free to free high range that is reserved before.

Right, memblock_double_array need avoid the required region. Will
repost.

>
> Thanks
>
> Yinghai


\
 
 \ /
  Last update: 2015-07-28 02:01    [W:0.072 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site