lkml.org 
[lkml]   [2015]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking
Date
On Friday 24 July 2015 22:27:39 Andrew F. Davis wrote:
> On 07/23/2015 11:22 AM, Pali Rohár wrote:
> > On Wednesday 22 July 2015 16:52:00 Andrew F. Davis wrote:
> >> + /* Unlikely but important to return first */
> >> + if (bq27xxx_battery_overtemp(di, flags))
> >> + return POWER_SUPPLY_HEALTH_OVERHEAT;
> >> + if (bq27xxx_battery_undertemp(di, flags))
> >> + return POWER_SUPPLY_HEALTH_COLD;
> >> + if (bq27xxx_battery_dead(di, flags))
> >> + return POWER_SUPPLY_HEALTH_DEAD;
> >
> > Good candidates for "if (unlikely(...))" ?
>
> I wasn't sure, but I don't see why not. Added.
>

You wrote "Unlikely" in comment, so I thought that unlikely macro sounds
reasonable here...

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-07-24 23:21    [W:0.112 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site