lkml.org 
[lkml]   [2015]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] perf: x86: Improve accuracy of perf/sched clock
On Fri, Jul 24, 2015 at 04:39:55PM +0300, Adrian Hunter wrote:
> @@ -251,17 +253,17 @@ static void set_cyc2ns_scale(unsigned long cpu_khz, int cpu)
> rdtscll(tsc_now);
> ns_now = cycles_2_ns(tsc_now);
>
> - /*
> - * Compute a new multiplier as per the above comment and ensure our
> - * time function is continuous; see the comment near struct
> - * cyc2ns_data.
> - */

I'd leave this comment, but update the one this refers to; esp. the bit
that explains why 10.

Also, I think you can remove the definition of CYC2NS_SCALE_FACTOR.

Other than that, seems like a good idea.


\
 
 \ /
  Last update: 2015-07-24 17:21    [W:0.036 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site