Messages in this thread | | | Date | Fri, 24 Jul 2015 15:33:43 +0200 | From | Peter Zijlstra <> | Subject | Re: Dealing with the NMI mess |
| |
On Fri, Jul 24, 2015 at 03:30:13PM +0200, Peter Zijlstra wrote: > > > But do we care if we do hit one? The return from the #DB handler can > > > use a RET. Right? > > Look at do_debug(), it has lovely bits like: > > preempt_conditional_sti(); > > in it, we do _NOT_ want to be re-enabling interrupts if we're called > from an !IF context, that'd be _bad_.
Ah, I forgot the conditional thing was the STI depending on regs->flags & IF..
In any case, better safe than sorry and simply not do #DB ever if !IF.
| |