Messages in this thread | | | Date | Fri, 24 Jul 2015 18:03:38 +0530 | Subject | Re: [PATCH] power_supply: Adjust devm usage | From | Vaishali Thakkar <> |
| |
On Fri, Jul 24, 2015 at 5:56 PM, Sebastian Reichel <sre@kernel.org> wrote: > Hi,
Hi
> Thanks for the cleanup patch. > I have a couple of comments inlined. > >> Subject: Re: [PATCH] power_supply: Adjust devm usage > > Please make this "power_supply: bq24735: ...".
Ok. Sure.
> On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > Please also use devm_power_supply_unregister() instead > of power_supply_unregister() to further simplify the driver.
Ok.
>> @@ -267,8 +267,9 @@ static int bq24735_charger_probe() {} >> [...] > > Your patch is missing removal of the > kfree(charger->charger_desc.name) in bq24735_charger_remove().
Yes. Because it seems that this kfree is freeing some other data which is not related to devm_kzalloc. I was not sure about removing it. So, I was about to discuss it in a separate thread. Also, in the remove function we have devm_free_irq. I am unsure it too. Because normally remove functions do not use devm counterparts.
> -- Sebastian
-- Vaishali
| |