Messages in this thread | | | Date | Fri, 24 Jul 2015 21:29:25 +0900 | Subject | Re: [PATCH] power_supply: Adjust devm usage | From | Krzysztof Kozlowski <> |
| |
2015-07-24 21:17 GMT+09:00 Frans Klaver <fransklaver@gmail.com>: > Hi, > > On Fri, Jul 24, 2015 at 1:58 PM, Vaishali Thakkar > <vthakkar1994@gmail.com> wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > If there's to be a respin, reword this so that it becomes clearer that > removing the various gotos and the label is an effect of using > devm_kasprintf here. I started out thinking that this patch did two > things.
And please put a driver prefix in the subject (like in rest of commits). Beside of that: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
| |