lkml.org 
[lkml]   [2015]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC 1/3] docs: dts: Added documentation for Xilinx Zynq PL Reset bindings.
    From
    Date
    On 07/24/2015 12:51 AM, Moritz Fischer wrote:
    > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
    > ---
    > Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 +++++++++++++
    > 1 file changed, 13 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
    >
    > diff --git a/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
    > new file mode 100644
    > index 0000000..ac4499e
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
    > @@ -0,0 +1,13 @@
    > +Xilinx Zynq PL Reset Manager

    I think there is no reason to be just PL specific.
    > +
    > +Required properties:
    > +- compatible: "xlnx,zynq-reset-pl"
    > +- syscon <&slcr>;
    > +- #reset-cells: 1
    > +
    > +Example:
    > + rstc: rstc@240 {

    @200 then here

    > + #reset-cells = <1>;
    > + compatible = "xlnx,zynq-reset-pl";

    Compatible should be first below node name.

    You should add also reg property 0x200 0x50

    > + syscon = <&slcr>;
    > + };
    >

    Thanks,
    Michal


    \
     
     \ /
      Last update: 2015-07-24 07:21    [W:4.795 / U:0.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site