Messages in this thread Patch in this message | | | From | Andy Lutomirski <> | Subject | [PATCH v2] x86/entry/32: Remove duplicate initialization of tss.ss1 | Date | Thu, 23 Jul 2015 12:14:41 -0700 |
| |
It's statically initialized, so we don't need to dynamically initialize it too.
Reported-by: Brian Gerst <brgerst@gmail.com> Signed-off-by: Andy Lutomirski <luto@kernel.org> ---
Changes since v1: Delete the code :)
arch/x86/kernel/cpu/common.c | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index e2ed2513a51e..e08eee98a5f8 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1005,14 +1005,6 @@ void enable_sep_cpu(void) if (IS_ENABLED(CONFIG_X86_32) && !boot_cpu_has(X86_FEATURE_SEP)) goto out; -#ifdef CONFIG_X86_32 - /* - * We cache MSR_IA32_SYSENTER_CS's value in the TSS's ss1 field -- - * see the big comment in struct x86_hw_tss's definition. - */ - tss->x86_tss.ss1 = __KERNEL_CS; -#endif - wrmsrl_safe(MSR_IA32_SYSENTER_CS, __KERNEL_CS); wrmsrl_safe(MSR_IA32_SYSENTER_ESP, (unsigned long)tss + -- 2.4.3
| |