Messages in this thread | | | From | Ian Abbott <> | Subject | [PATCH 0/6] staging: comedi: usbduxsigma: fix some problems in command handling | Date | Thu, 23 Jul 2015 16:46:56 +0100 |
| |
Fix some minor problems in the testing of asynchronous commands for the AI and AO subdevices and remove some redundant code.
The main problem is that the testing of a new command can affect the operation of an already running command, which it isn't supposed to do. (In practice, applications don't tend to test new commands while a command is running on the same subdevice, so the bug can be classed as minor.) This is corrected by the patches 1 and 2, for the AI and AO subdevices, respectively.
1) staging: comedi: usbduxsigma: don't clobber ai_timer in command test 2) staging: comedi: usbduxsigma: don't clobber ao_timer in command test 3) staging: comedi: usbduxsigma: remove AI scan_begin_src == TRIG_FOLLOW 4) staging: comedi: usbduxsigma: round down AI scan_begin_arg at step 4. 5) staging: comedi: usbduxsigma: remove unused "convert" timing for AO 6) staging: comedi: usbduxsigma: round down AO scan_begin_arg at step 4.
drivers/staging/comedi/drivers/usbduxsigma.c | 139 +++++++++++---------------- 1 file changed, 54 insertions(+), 85 deletions(-)
| |