lkml.org 
[lkml]   [2015]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/Kconfig: NEED_BOUNCE_POOL: clean-up condition
On Thu 23-07-15 13:18:06, Valentin Rothberg wrote:
> commit 106542e7987c ("fs: Remove ext3 filesystem driver") removed ext3
> and JBD, hence remove the superfluous condition.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
> I detected the issue with undertaker-checkpatch
> (https://undertaker.cs.fau.de)

Thanks. I have added your patch into my tree. BTW, is the checker automated
enough that it could be made part of the 0-day tests Fengguang runs?

Honza

> mm/Kconfig | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index e79de2bd12cd..d4e6495a720f 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -299,15 +299,9 @@ config BOUNCE
> # On the 'tile' arch, USB OHCI needs the bounce pool since tilegx will often
> # have more than 4GB of memory, but we don't currently use the IOTLB to present
> # a 32-bit address to OHCI. So we need to use a bounce pool instead.
> -#
> -# We also use the bounce pool to provide stable page writes for jbd. jbd
> -# initiates buffer writeback without locking the page or setting PG_writeback,
> -# and fixing that behavior (a second time; jbd2 doesn't have this problem) is
> -# a major rework effort. Instead, use the bounce buffer to snapshot pages
> -# (until jbd goes away). The only jbd user is ext3.
> config NEED_BOUNCE_POOL
> bool
> - default y if (TILE && USB_OHCI_HCD) || (BLK_DEV_INTEGRITY && JBD)
> + default y if TILE && USB_OHCI_HCD
>
> config NR_QUICK
> int
> --
> 1.9.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR


\
 
 \ /
  Last update: 2015-07-23 16:01    [W:0.228 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site