lkml.org 
[lkml]   [2015]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[char-misc-next 05/15 V3] mei: bus: don't enable events implicitly in device enable
Date
Do not enable events implicitly in mei_cl_enable_device, it should be
done explicitly using mei_cl_register_event_cb so the events
are enabled only when needed.
The NFC drivers has been already using it that way so no need for
further changes just remove the code from mei_cl_enable_device.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
V2: fix the commit message
V3: rebase
drivers/misc/mei/bus.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index bec213b92550..257e200b5343 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -332,9 +332,6 @@ int mei_cl_enable_device(struct mei_cl_device *cldev)

mutex_unlock(&bus->device_lock);

- if (cldev->event_cb)
- mei_cl_read_start(cldev->cl, 0, NULL);
-
return 0;
}
EXPORT_SYMBOL_GPL(mei_cl_enable_device);
--
2.4.3


\
 
 \ /
  Last update: 2015-07-23 14:41    [W:0.058 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site