Messages in this thread | | | Date | Thu, 23 Jul 2015 13:19:38 +0200 | From | Noralf Trønnes <> | Subject | Re: [PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op |
| |
Den 15.07.2015 04:14, skrev Greg KH: > On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote: >> Use a helper function to choose which set_addr_win implementation to >> use, based on the value of the setaddrwin module parameter. >> >> Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> >> --- >> drivers/staging/fbtft/flexfb.c | 47 +++++++++++++++++++++++++----------------- >> 1 file changed, 28 insertions(+), 19 deletions(-) > Again, why? > > I need a maintainer of the code to ack any of these... >
I know this code fairly well, but I have to look up the details. Moving these details from the probe function into small functions makes it more difficult for me get to those details in a glance. I would now have to scroll back and forth to see how flexfb is doing things, especially since flexfb differs from the other drivers which uses common functions in fbtft-core.c. So I prefer to keep it as it is.
| |