Messages in this thread | | | Date | Thu, 23 Jul 2015 02:46:51 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests |
| |
On Tue, Jul 21, 2015 at 03:07:55PM -0700, Spencer Baugh wrote: > From: Dilip Kumar Uppugandla <dilip@purestorage.com> > > Invoking get_cmd_state for qla2xxx always returns 0. Instead change it > to return the actual fabric state from qla_tgt_cmd. This will help with > debugging.
I think the ->get_cmd_state callback should go away instead. Returning values with zero meaning to the core in a callback doesn't make much sense. I'd rather build some real structured debugging infrastructure, so it would be useful if you could explain the use case for this.
| |