Messages in this thread | | | Date | Thu, 23 Jul 2015 10:59:18 +0200 | From | Roger Pau Monné <> | Subject | Re: [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent |
| |
El 22/07/15 a les 8.40, Bob Liu ha escrit: > We should consider info->feature_persistent when adding indriect page to list ^ indirect > info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered. > > Signed-off-by: Bob Liu <bob.liu@oracle.com>
Thanks, this looks correct indeed. If we are using persistent grants the indirect_pages list should always be empty because blkfront has pre-allocated enough persistent pages to fill all requests on the ring.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Should be backported to stable branches.
Roger.
| |