lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] IB/mlx5/hmm: add mlx5 HMM device initialization and callback v3.
On Tue, Jul 21, 2015 at 11:14:59AM -0400, Jerome Glisse wrote:
> This is a rebase error. But the #error is there for a purpose the HMM
> would not work mid way so if anyone if bisecting up through that i would
> rather error out at compilation.

Add the kconfig option last not first?

Also, can you use 'if (IS_ENABLED(XXX))' as much as possible? Some of
the existing ODP checks looked like it should use that as well..

Jason


\
 
 \ /
  Last update: 2015-07-21 18:21    [W:0.069 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site