Messages in this thread | | | Date | Tue, 21 Jul 2015 15:30:51 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 08/10] arch: introduce strict_ioremap |
| |
On Sun, Jul 19, 2015 at 08:18:17PM -0400, Dan Williams wrote: > In preparation for enabling memremap(), add support for strict mappings. > strict_ioremap_<type>() returns NULL if the arch does not implement the > mapping type, rather than falling back silently to ioremap().
Please don't introduce another large number of ioremap variants.
I think we should go straight to the ioremap_flags variant, although I wonder if we should even bother with ioremap_flags for this use case, given that we really want memremap-like semantics for anything that isn't plain ioremap (and maybe ioremap_nocache).
Sorry or being the downer, but I really think we need to clean up this mess deeply insted of trying to paper over it.
| |