Messages in this thread | | | Date | Tue, 21 Jul 2015 13:37:57 +0300 | From | Haggai Eran <> | Subject | Re: [PATCH 4/8] IB/odp/hmm: add new kernel option to use HMM for ODP. |
| |
On 17/07/2015 22:01, Jérôme Glisse wrote: > This is a preparatory patch for HMM implementation of ODP (on demand > paging). It introduce a new configure option and add proper build > time conditional code section. Enabling INFINIBAND_ON_DEMAND_PAGING_HMM > will result in build error with this patch. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > --- ... > diff --git a/include/rdma/ib_umem_odp.h b/include/rdma/ib_umem_odp.h > index 3da0b16..765aeb3 100644
> @@ -100,28 +124,13 @@ void ib_umem_odp_release(struct ib_umem *umem); > > #define ODP_DMA_ADDR_MASK (~(ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWED_BIT)) > > + Please avoid adding double blank lines. You can find more of these by running checkpatch on the patch.
Other than that: Reviewed-by: Haggai Eran <haggaie@mellanox.com>
| |