Messages in this thread | | | Date | Mon, 20 Jul 2015 18:02:52 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 15/16] scripts: Make checkpatch.pl warn on expedited RCU grace periods |
| |
On Mon, Jul 20, 2015 at 05:48:40PM -0700, Joe Perches wrote: > On Mon, 2015-07-20 at 17:41 -0700, Paul E. McKenney wrote: > > On Fri, Jul 17, 2015 at 03:37:54PM -0700, Joe Perches wrote: > > > It'd be faster perl without capture groups: > > > > > > if ($line =~ /\b(?:synchronize_(?:rcu|sched)_expedited)\s*\(/) { > > > > Fair enough, but this pattern is used rather heavily in this script, > > and I don't trust my perl enough to want to create a new pattern. > > > > I see a couple of possible ways forward: > > > > 1. I hand this patch off to you, and you update it as you deem fit. > > > > 2. I push the patch as is (after the fix below) and you update > > checkpatch as a whole to use the more efficient code. > > > > How would you like to proceed? > > Push and fix would work fine.
Very good, will do!
Thanx, Paul
| |