lkml.org 
[lkml]   [2015]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iommu-common: Do not use 64 bit constant 0xffffffffffffffffl for computing align_mask
On (07/19/15 08:27), Guenter Roeck wrote:
> > - align_mask = 0xffffffffffffffffl >> (64 - align_order);
> > + align_mask = ~0l >> (64 - align_order);
> >
> Wonder if this just hides the real problem. Unless align_order
> is very large, the resulting mask on 32 bit systems may be 0.
> Is this really the idea ?

<subsequent example code deleted>

> So either case ~0l appears to be wrong; it should be ~0ul.
> I don't know if ~0ull makes a difference for some architectures.

I agree about the unsigned part. However, regarding the arch specific
twists..

I checked into this.. even though I have a test program on
x86_64 that "does the right thing" for both of

align_mask = ~0ul >> (64 - align_order);
align_mask = ~0ul >> (BITS_PER_LONG - align_order);

when I compiled with -m32 and without (I tried align_order == 1 and 31
for edge cases), I think there are some gcc/arch specific variations
possible based on undefined behavior, so that the second variant
is safer.

I'll send out a patch with that version soon.

--Sowmini



\
 
 \ /
  Last update: 2015-07-20 17:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog