Messages in this thread | | | Date | Thu, 2 Jul 2015 10:50:05 +0300 | Subject | Re: running out of tags in 9P (was Re: [git pull] vfs part 2) | From | Andrey Ryabinin <> |
| |
[repeating, since my previous email didn't reach mailing lists]
2015-07-02 7:10 GMT+03:00 Al Viro <viro@zeniv.linux.org.uk>: >> It should be easy to confirm - in p9_client_prepare_req() add >> if (WARN_ON_ONCE(tag != (u16)tag)) { >> p9_idpool_put(tag, c->tagpool); >> return ERR_PTR(-ENOMEM); >> } >> right after >> tag = p9_idpool_get(c->tagpool); >> if (tag < 0) >> return ERR_PTR(-ENOMEM); >> >> and see if it triggers. I'm not sure if failing with ENOMEM is the >> right response (another variant is to sleep there until the pile >> gets cleaned or until we get killed), and WARN_ON_ONCE() is definitely >> not for the real work, but it will do for confirming that this is what >> we are hitting. >
Apparently, I'm seeing something else. That WARN_ON_ONCE didn't trigger.
| |