lkml.org 
[lkml]   [2015]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] net-RDS: Delete an unnecessary check before the function call "module_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 2 Jul 2015 17:58:21 +0200

    The module_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/rds/transport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/rds/transport.c b/net/rds/transport.c
    index 8b4a6cd..83498e1 100644
    --- a/net/rds/transport.c
    +++ b/net/rds/transport.c
    @@ -73,7 +73,7 @@ EXPORT_SYMBOL_GPL(rds_trans_unregister);

    void rds_trans_put(struct rds_transport *trans)
    {
    - if (trans && trans->t_owner)
    + if (trans)
    module_put(trans->t_owner);
    }

    --
    2.4.5


    \
     
     \ /
      Last update: 2015-07-02 18:21    [W:4.022 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site