Messages in this thread | | | From | (Krzysztof Hałasa) | Subject | Re: [PATCH] defines modified to match the 80-char rule | Date | Wed, 01 Jul 2015 09:59:33 +0200 |
| |
Mario Bambagini <mario.bambagini@gmail.com> writes:
> Defines have been written in more than one line to match the 80-character > rule. This error has been fixed 6 times in this file. > The file is fully compliant with respect to the coding rules now.
Rules, maybe. But is it better, i.e., more readable?
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h > +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h > @@ -233,14 +233,20 @@ do { \ > #define CNETERR(format, a...) CDEBUG_LIMIT(D_NETERROR, format, ## a) > #define CEMERG(format, ...) CDEBUG_LIMIT(D_EMERG, format, ## __VA_ARGS__) > > -#define LCONSOLE(mask, format, ...) CDEBUG(D_CONSOLE | (mask), format, ## __VA_ARGS__) > -#define LCONSOLE_INFO(format, ...) CDEBUG_LIMIT(D_CONSOLE, format, ## __VA_ARGS__) > -#define LCONSOLE_WARN(format, ...) CDEBUG_LIMIT(D_CONSOLE | D_WARNING, format, ## __VA_ARGS__) > -#define LCONSOLE_ERROR_MSG(errnum, format, ...) CDEBUG_LIMIT(D_CONSOLE | D_ERROR, \ > - "%x-%x: " format, errnum, LERRCHKSUM(errnum), ## __VA_ARGS__) > -#define LCONSOLE_ERROR(format, ...) LCONSOLE_ERROR_MSG(0x00, format, ## __VA_ARGS__) > +#define LCONSOLE(mask, format, ...) \ > + CDEBUG(D_CONSOLE | (mask), format, ## __VA_ARGS__) > +#define LCONSOLE_INFO(format, ...) \ > + CDEBUG_LIMIT(D_CONSOLE, format, ## __VA_ARGS__) > +#define LCONSOLE_WARN(format, ...) \ > + CDEBUG_LIMIT(D_CONSOLE | D_WARNING, format, ## __VA_ARGS__) > +#define LCONSOLE_ERROR_MSG(errnum, format, ...) \ > + CDEBUG_LIMIT(D_CONSOLE | D_ERROR, "%x-%x: " format, \ > + errnum, LERRCHKSUM(errnum), ## __VA_ARGS__) > +#define LCONSOLE_ERROR(format, ...) \ > + LCONSOLE_ERROR_MSG(0x00, format, ## __VA_ARGS__) > > -#define LCONSOLE_EMERG(format, ...) CDEBUG(D_CONSOLE | D_EMERG, format, ## __VA_ARGS__) > +#define LCONSOLE_EMERG(format, ...) \ > + CDEBUG(D_CONSOLE | D_EMERG, format, ## __VA_ARGS__) > > int libcfs_debug_msg(struct libcfs_debug_msg_data *msgdata, > const char *format1, ...)
... I don't think so. Perhaps if I wasn't using the bleading edge tech 132-column digital flat LCD screen, I would see this differently (Emacs isn't perfect when displaying long lines on IBM monochrome display adapter, even with the intelligent-long-lines-wrap package). -- Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland
| |