Messages in this thread | | | From | Chao Yu <> | Subject | RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option | Date | Thu, 2 Jul 2015 20:35:34 +0800 |
| |
> -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, June 30, 2015 2:40 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option > > This patch adds noextent_cache mount option.
How about adding some descriptions in Documentation to help our user?
The other thing is we'd better to show 'noextent_cache' option when user lookups the mount options.
How about adding codes as below? if (test_opt(sbi, EXTENT_CACHE)) seq_puts(seq, ",extent_cache"); +else + seq_puts(seq, ",noextent_cache");
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
The other looks good to me, so please add:
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
| |