Messages in this thread | | | Date | Sun, 19 Jul 2015 21:17:17 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf: fix makefile generation under dash |
| |
On Sun, Jul 19, 2015 at 10:30:05AM +0100, Sergei Trofimovich wrote: > Under dash 'echo -n' yields '-n' to stdout. > Use printf "" instead.
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
> > CC: Peter Zijlstra <a.p.zijlstra@chello.nl> > CC: Ingo Molnar <mingo@redhat.com> > CC: Arnaldo Carvalho de Melo <acme@kernel.org> > CC: Jiri Olsa <jolsa@redhat.com> > CC: Namhyung Kim <namhyung@kernel.org> > CC: Adrian Hunter <adrian.hunter@intel.com> > CC: linux-kernel@vger.kernel.org > Signed-off-by: Sergei Trofimovich <siarheit@google.com> > --- > tools/perf/config/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 094ddae..bc0b59e 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -11,7 +11,7 @@ ifneq ($(obj-perf),) > obj-perf := $(abspath $(obj-perf))/ > endif > > -$(shell echo -n > $(OUTPUT).config-detected) > +$(shell printf "" > $(OUTPUT).config-detected) > detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected) > detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected) > > -- > 2.4.6 >
| |