lkml.org 
[lkml]   [2015]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 02/21] stackvalidate: Add C version of STACKVALIDATE_IGNORE_INSN
On Fri, Jul 17, 2015 at 11:47:18AM -0500, Josh Poimboeuf wrote:
> Add a C inline asm string version of the STACKVALIDATE_IGNORE_INSN macro
> which tells stackvalidate to ignore the subsequent instruction.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> arch/x86/include/asm/stackvalidate.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/x86/include/asm/stackvalidate.h b/arch/x86/include/asm/stackvalidate.h
> index 2d23c23..dac935c 100644
> --- a/arch/x86/include/asm/stackvalidate.h
> +++ b/arch/x86/include/asm/stackvalidate.h
> @@ -23,6 +23,15 @@
> .endif
> .endm
>
> +#else /* !__ASSEMBLY__ */
> +

#ifdef CONFIG_STACK_VALIDATION

> +#define STACKVALIDATE_IGNORE_INSN \
> + ".Ltemp" __stringify(__LINE__) ":;" \
> + ".pushsection __stackvalidate_ignore_insn, \"a\";" \
> + _ASM_ALIGN ";" \
> + ".long .Ltemp" __stringify(__LINE__) " - .;" \
> + ".popsection;"
> +

#endif


Also, you should end your lines with "\n" so that the .s output looks
a bit more readable, not like now:

#APP
# 30 "./arch/x86/include/asm/arch_hweight.h" 1
661:
.Ltemp32:;.pushsection __stackvalidate_ignore_insn, "a"; .balign 8 ;.long .Ltemp32 - .;.popsection;call __sw_hweight32
662:

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--


\
 
 \ /
  Last update: 2015-07-18 17:21    [W:0.241 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site