lkml.org 
[lkml]   [2015]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 13/21] x86/asm/crypto: Fix frame pointer usage in aesni-intel_asm.S
On Sat, Jul 18, 2015 at 10:42:36AM +0200, Borislav Petkov wrote:
> On Fri, Jul 17, 2015 at 04:10:19PM -0500, Josh Poimboeuf wrote:
> > Actually I'm not done painting. Personally it seems a little too
> > verbose. I still like ENTRY_FRAME and ENDPROC_FRAME_RETURN :p
>
> Let's balance it out even more:
>
> ENTRY_FRAME(..)
>
> ...
>
> ENDPROC_FRAME(..)

I like the balance, but the "ret" is still non-obvious.

How about:

FRAME_ENTRY(...)

FRAME_RETURN(...)

--
Josh


\
 
 \ /
  Last update: 2015-07-18 16:01    [W:0.184 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site