Messages in this thread | | | Date | Sat, 18 Jul 2015 08:46:55 -0500 | From | Josh Poimboeuf <> | Subject | Re: [RFC PATCH 13/21] x86/asm/crypto: Fix frame pointer usage in aesni-intel_asm.S |
| |
On Sat, Jul 18, 2015 at 10:42:36AM +0200, Borislav Petkov wrote: > On Fri, Jul 17, 2015 at 04:10:19PM -0500, Josh Poimboeuf wrote: > > Actually I'm not done painting. Personally it seems a little too > > verbose. I still like ENTRY_FRAME and ENDPROC_FRAME_RETURN :p > > Let's balance it out even more: > > ENTRY_FRAME(..) > > ... > > ENDPROC_FRAME(..)
I like the balance, but the "ret" is still non-obvious.
How about:
FRAME_ENTRY(...)
FRAME_RETURN(...)
-- Josh
| |