Messages in this thread | | | Date | Fri, 17 Jul 2015 06:40:43 +0000 (GMT) | From | MyungJoo Ham <> | Subject | Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device |
| |
> > This patchset introduce the generic devfreq cooling device for generic thermal > framework. The devfreq devices are used ad cooling device to reduce the > overheating temperature. This patch is based on drivers/thermal/cpu_cooling.c. > The devfreq cooling device can change the ragne of the frequency table of > devfreq device according to cooling level in device tree file.
Hi,
1. You've exported "update_devfreq()" in 1/2 and didn't use it anywhere. 2. If you've added "update_devfreq()" to notify devfreq driver when a new max/min is defined, you'll need to add it at set_state, OR You may do it with opp_enable()/opp_disable() function and let opp notifiers do the homework for you. (no need to update_devfreq().
Cheers, MyungJoo
| |