lkml.org 
[lkml]   [2015]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature
Date
Dexuan Cui <decui@microsoft.com> writes:

>> From: David Miller
>> Sent: Thursday, July 16, 2015 12:19
>>
>> From: Dexuan Cui
>> Date: Tue, 14 Jul 2015 03:00:48 -0700
>>
>> > + pr_debug("hvsock_sk_destruct: called\n");
>>
>> Debug logging just to state that a function is called is not appropriate,
>> we have very sophisticated tracing facilities in the kernel that can do
>> that transparently, and more.
>>
>> Please remove this.
> OK.
>
>> > + if (hvsk->channel) {
>> > + pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
>>
>> Likewise, these kinds of debug logs are totally inappropriate.
> OK, I'll remove all the pr_debug() in the patch.
>

I'd suggest we rather use something like net_dbg_ratelimited()
intead. The driver is new so issues are expected. Some debugging may
be useful)

[...]

--
Vitaly


\
 
 \ /
  Last update: 2015-07-17 17:21    [W:0.058 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site