Messages in this thread | | | From | "Liang, Kan" <> | Subject | RE: [PATCH RFC V4 1/4] perf,tools: introduce callgraph_set for callgraph option | Date | Fri, 17 Jul 2015 14:24:30 +0000 |
| |
> > @@ -784,10 +785,11 @@ int record_parse_callchain_opt(const struct > option *opt __maybe_unused, > > return ret; > > } > > > > -int record_callchain_opt(const struct option *opt __maybe_unused, > > +int record_callchain_opt(const struct option *opt, > > const char *arg __maybe_unused, > > int unset __maybe_unused) > > { > > + *(bool *)opt->set = true; > > hum, how does this set callgraph_set ? > shouldn't it be 'callgraph_set = true' instead? >
Right, I mixed the patch with the previous one. It should be as below. I will fix it in next version.
Thanks, Kan @@ -789,7 +790,9 @@ int record_callchain_opt(const struct option *opt, const char *arg __maybe_unused, int unset __maybe_unused) { - *(bool *)opt->set = true; + struct record_opts *record = (struct record_opts *)opt->value; + + record->callgraph_set = true; callchain_param.enabled = true;
if (callchain_param.record_mode == CALLCHAIN_NONE)
| |