lkml.org 
[lkml]   [2015]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] mm, meminit: Allow early_pfn_to_nid to be used during runtime
On Fri, Jul 17, 2015 at 01:22:04PM +0100, Mel Gorman wrote:
> int __meminit early_pfn_to_nid(unsigned long pfn)
> {
> + static DEFINE_SPINLOCK(early_pfn_lock);
> int nid;
>
> - /* The system will behave unpredictably otherwise */
> - BUG_ON(system_state != SYSTEM_BOOTING);
> + /* Avoid locking overhead during boot but hotplug must lock */
> + if (system_state != SYSTEM_BOOTING)
> + spin_lock(&early_pfn_lock);
>
> nid = __early_pfn_to_nid(pfn, &early_pfnnid_cache);
> - if (nid >= 0)
> - return nid;
> - /* just returns 0 */
> - return 0;
> + if (nid < 0)
> + nid = 0;
> +
> + if (system_state != SYSTEM_BOOTING)
> + spin_unlock(&early_pfn_lock);
> +
> + return nid;
> }

Why the conditional locking?


\
 
 \ /
  Last update: 2015-07-17 15:21    [W:0.049 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site