Messages in this thread | | | Date | Fri, 17 Jul 2015 14:14:46 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume |
| |
* Borislav Petkov <bp@alien8.de> wrote:
> > EXPORT_SYMBOL_GPL(__static_cpu_has_safe); > > + > > +static void cpu_custom_resume(void) > > Let's call this bsp_resume() as it is run only on the boot CPU. > > > +{ > > + if (this_cpu->c_resume) > > + this_cpu->c_resume(&boot_cpu_data); > > +} > > So giving boot_cpu_data means, this is the boot CPU but you're assigning it to > c_resume() which means, every CPU. What you could do is call the function ptr > ->c_bsp_resume like the ->c_bsp_init which we already have so that it is clear > that it is run only on the BSP. > > Rest looks ok to me, unless tip guys have a better idea...
Looks good to me!
Ingo
| |