Messages in this thread |  | | Date | Thu, 16 Jul 2015 21:32:32 +0100 | | From | Mark Brown <> | | Subject | Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1 |
| |
On Thu, Jul 16, 2015 at 11:46:58PM +0530, Vaibhav Hiremath wrote:
> .disable = regulator_disable_regmap, > .is_enabled = regulator_is_enabled_regmap, > .get_current_limit = pm800_get_current_limit, > + .set_current_limit = pm800_set_current_limit,
set_current_limit() isn't the right interface to use for this, this is something that depends on the physical design of the system rather than something that limits the current. It should be a DT property of its own. There are some other PMICs with similar functions but it's not clear yet how generic the configuration mechanism is. [unhandled content-type:application/pgp-signature] |  |