Messages in this thread | | | Date | Thu, 16 Jul 2015 18:13:42 +0200 | From | Michal Kubecek <> | Subject | Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support |
| |
On Thu, Jul 16, 2015 at 10:50:59AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: > > @@ -278,6 +292,14 @@ static int sctp_new_state(enum ip_conntrack_dir dir, > > pr_debug("SCTP_CID_SHUTDOWN_COMPLETE\n"); > > i = 8; > > break; > > + case SCTP_CID_HEARTBEAT: > > + pr_debug("SCTP_CID_HEARTBEAT"); > > + i = 9; > > + break; > > + case SCTP_CID_HEARTBEAT_ACK: > > + pr_debug("SCTP_CID_HEARTBEAT_ACK"); > > + i = 10; > > + break; > > default: > > /* Other chunks like DATA, SACK, HEARTBEAT and > > its ACK do not cause a change in state */ > > Would you update this comment on default case please? As with this > patch, HB and its ACK may cause a change in state.
Thank you for catching this. I'll update the comment in v2 I'm going to send tomorrow after some testing.
Michal Kubecek
| |