Messages in this thread Patch in this message | | | Subject | Re: Checkpatch: False positive | From | Joe Perches <> | Date | Thu, 16 Jul 2015 08:58:56 -0700 |
| |
On Thu, 2015-07-16 at 16:43 +0100, Andy Whitcroft wrote: > On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote: > > > #31: > > > arch/x86/kernel/hpet.c | 198 ++++++++++++++++++++++++++--------------- > > I guess those are in the limbo land between the end of message and > beginning of the patch itself. Perhaps the test should at least stop at > the end of header marker, at the '---'. > > -apw
Maybe, but the test already stops at signatures like Signed-off-by: that should always be above the ---.
This might help, but there are _many_ false positives.
The other thing that might help is for people to take the warnings the script produces less seriously.
Maybe convert:
ERROR -> defect WARNING -> unstylish CHECK -> nitpick
or some such
---
scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d5ce29a..5e7afa7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2213,6 +2213,11 @@ sub process { $in_commit_log = 0; } +# Check for patch separator + if ($line =~ /^---$/) { + $in_commit_log = 0; + } + # Check if MAINTAINERS is being updated. If so, there's probably no need to # emit the "does MAINTAINERS need updating?" message on file add/move/delete if ($line =~ /^\s*MAINTAINERS\s*\|/) {
| |