lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 247/251] USB: devio: fix a condition in async_completed()
    Date
    3.19.8-ckt4 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 83ed07c5db71bc02bd646d6eb60b48908235cdf9 upstream.

    Static checkers complain that the current condition is never true. It
    seems pretty likely that it's a typo and "URB" was intended instead of
    "USB".

    Fixes: 3d97ff63f899 ('usbdevfs: Use scatter-gather lists for large bulk transfers')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/usb/core/devio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
    index e500243..fae81924 100644
    --- a/drivers/usb/core/devio.c
    +++ b/drivers/usb/core/devio.c
    @@ -513,7 +513,7 @@ static void async_completed(struct urb *urb)
    snoop(&urb->dev->dev, "urb complete\n");
    snoop_urb(urb->dev, as->userurb, urb->pipe, urb->actual_length,
    as->status, COMPLETE, NULL, 0);
    - if ((urb->transfer_flags & URB_DIR_MASK) == USB_DIR_IN)
    + if ((urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN)
    snoop_urb_data(urb, urb->actual_length);

    if (as->status < 0 && as->bulk_addr && as->status != -ECONNRESET &&
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-07-16 03:21    [W:4.072 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site