lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] staging: sm7xxfb: define new macros
On Tue, Jul 14, 2015 at 08:05:08PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote:
> > +#define mmio_addr 0x00c00000
> > +#define seqw17
>
> Odd, empty macros are not good, because:
>
> > -#ifdef __BIG_ENDIAN
> > if (sfb->fb->var.bits_per_pixel == 32)
> > - smtc_seqw(0x17, 0x30);
> > -#endif
> > + seqw17;
>
> That just looks wrong :(
I think it will look better in c file if I make it as
#define seqw17()
I will respin the patches and send.

regards
sudip


\
 
 \ /
  Last update: 2015-07-15 07:21    [W:0.058 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site