lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 014/251] amd-xgbe: Add the __GFP_NOWARN flag to Rx buffer allocation
    Date
    3.19.8-ckt4 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tom Lendacky <thomas.lendacky@amd.com>

    [ Upstream commit 472cfe7127760d68b819cf35a26e5a1b44b30f4e ]

    When allocating Rx related buffers, alloc_pages is called using an order
    number that is decreased until successful. A system under stress can
    experience failures during this allocation process resulting in a warning
    being issued. This message can be of concern to end users even though the
    failure is not fatal. Since the failure is not fatal and can occur
    multiple times, the driver should include the __GFP_NOWARN flag to
    suppress the warning message from being issued.

    Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/ethernet/amd/xgbe/xgbe-desc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
    index a50891f..b873734 100644
    --- a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
    +++ b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
    @@ -263,7 +263,7 @@ static int xgbe_alloc_pages(struct xgbe_prv_data *pdata,
    int ret;

    /* Try to obtain pages, decreasing order if necessary */
    - gfp |= __GFP_COLD | __GFP_COMP;
    + gfp |= __GFP_COLD | __GFP_COMP | __GFP_NOWARN;
    while (order >= 0) {
    pages = alloc_pages(gfp, order);
    if (pages)
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-07-16 04:41    [W:4.141 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site