lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 062/251] usb: dwc3: gadget: don't clear EP_BUSY too early
    Date
    3.19.8-ckt4 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felipe Balbi <balbi@ti.com>

    commit e18b7975c885bc3a938b9a76daf32957ea0235fa upstream.

    In case of non-Isochronous transfers, we don't
    want to clear DWC3_EP_BUSY flag until XferComplete
    event. That's because XferInProgress was only enabled
    so we can recycle TRBs and usb_requests quicker, but
    there are still other pending requests being transferred.

    In order to make sure we don't allow for another StartTransfer
    command while the HW is still processing other transfers,
    we must keep DWC3_EP_BUSY flag set and this what this patch
    does.

    Fixes: f3af36511e60 (usb: dwc3: gadget: always enable IOC on
    bulk/interrupt transfers)
    Reported-by: sundeep subbaraya <sundeep.lkml@gmail.com>
    Tested-by: sundeep subbaraya <sundeep.lkml@gmail.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/usb/dwc3/gadget.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
    index 4efd3bd..5496218 100644
    --- a/drivers/usb/dwc3/gadget.c
    +++ b/drivers/usb/dwc3/gadget.c
    @@ -1906,12 +1906,16 @@ static void dwc3_endpoint_transfer_complete(struct dwc3 *dwc,
    {
    unsigned status = 0;
    int clean_busy;
    + u32 is_xfer_complete;
    +
    + is_xfer_complete = (event->endpoint_event == DWC3_DEPEVT_XFERCOMPLETE);

    if (event->status & DEPEVT_STATUS_BUSERR)
    status = -ECONNRESET;

    clean_busy = dwc3_cleanup_done_reqs(dwc, dep, event, status);
    - if (clean_busy)
    + if (clean_busy && (is_xfer_complete ||
    + usb_endpoint_xfer_isoc(dep->endpoint.desc)))
    dep->flags &= ~DWC3_EP_BUSY;

    /*
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-07-16 04:21    [W:2.405 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site