| Date | Tue, 14 Jul 2015 17:35:37 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH 35/42] x86, boot, PCI: Convert SETUP_PCI data to list |
| |
On Tue, Jul 07, 2015 at 01:20:21PM -0700, Yinghai Lu wrote: > So we could avoid ioremap every time later.
The changelog (not just the subject) should say what you're doing.
> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c > index 16ace12..32d4f21 100644 > --- a/arch/x86/pci/common.c > +++ b/arch/x86/pci/common.c
> +struct firmware_setup_pci_entry { > + struct list_head list; > + uint16_t vendor; > + uint16_t devid; > + uint64_t pcilen;
Is there a reason to use uint16_t and uint64_t instead of u16 and u64?
> + unsigned long segment; > + unsigned long bus; > + unsigned long device; > + unsigned long function; > + phys_addr_t romdata; > +};
|