lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 2/4] x86/stackvalidate: Compile-time stack validation
On Tue, Jul 14, 2015 at 04:30:34PM -0500, Josh Poimboeuf wrote:

> > How (if it does at all) deal with function-trace / -pg -fprofile-arcs
> > things? Does it silently ignore the __mcount calls and assumes ftrace
> > knows wtf its doing? ;-)
>
> Adding Steven to CC to keep me honest.
>
> In the case of "-pg -mfentry", which is what ftrace has relied on for

Ah -mfentry is the magic word, I couldn't find it and a grep led me
astray.

> the past few years for newer versions of gcc, stackvalidate silently
> ignores __fentry__ calls and assumes that ftrace indeed knows wtf it's
> doing. I don't see a problem there as long as the ftrace handler
> doesn't sleep.

They should not indeed, however it would be very nice if backtraces
would still be 'good'.

> I haven't run stackvalidate on the old "-pg" mcount non-fentry stuff,
> but I think it creates a stack frame before calling mcount, so it should
> be fine.

Ok.

> I don't know much about -fprofile-arcs, but as far as I can tell, it's
> only used for gcov.

Right, nobody much uses that I think.


\
 
 \ /
  Last update: 2015-07-15 00:21    [W:1.096 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site