lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] iio: magnetometer: mmc35240: fix SET/RESET sequence
From
Date


On 14 July 2015 15:56:54 BST, Daniel Baluta <daniel.baluta@intel.com> wrote:
>From: Viorel Suman <viorel.suman@intel.com>
>
>The RESET operation invoked in the last instance will align
>in the natural way all 3 axis and the chip top view.
What is the result of the bug?
Just trying to assess urgency of the patch!
>
>Signed-off-by: Viorel Suman <viorel.suman@intel.com>
>Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>---
> drivers/iio/magnetometer/mmc35240.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/iio/magnetometer/mmc35240.c
>b/drivers/iio/magnetometer/mmc35240.c
>index f4d7495..a53efd2 100644
>--- a/drivers/iio/magnetometer/mmc35240.c
>+++ b/drivers/iio/magnetometer/mmc35240.c
>@@ -215,14 +215,15 @@ static int mmc35240_init(struct mmc35240_data
>*data)
>
> /*
> * make sure we restore sensor characteristics, by doing
>- * a RESET/SET sequence
>+ * a SET/RESET sequence, the axis polarity being naturally
>+ * aligned after RESET
> */
>- ret = mmc35240_hw_set(data, false);
>+ ret = mmc35240_hw_set(data, true);
> if (ret < 0)
> return ret;
> usleep_range(MMC53240_WAIT_SET_RESET, MMC53240_WAIT_SET_RESET + 1);
>
>- ret = mmc35240_hw_set(data, true);
>+ ret = mmc35240_hw_set(data, false);
> if (ret < 0)
> return ret;
>

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


\
 
 \ /
  Last update: 2015-07-14 22:21    [W:0.089 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site