lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT
From
Date
On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote:
> On 07/13/2015 05:11 PM, Bastien Nocera wrote:
> > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/
> > focu
> > s=127896
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
>
> Bastien,
>
> The subject of this patch needs a bit more detail. I know that you
> mean the
> RTL8723B versions of the Bluetooth devices. The subject should say
> this.
>
> The commit message needs a bit more detail. Referencing the E-mail
> thread is OK,
> but a bit more is needed. What fails without this change?
>
> To help keep that patches straight, change the next submission to say
> "[PATCH
> V2]" in the subject. In addition, after the ---, add a section saying
> what
> changed in V2. That info is not retained in the final commit message
> in the
> repo, but it can be very useful to a maintainer.
>

And while at it, please use links that include the message-id (e.g.
mid.gmane.org) so it's searchable even if the archive disappears.

johannes


\
 
 \ /
  Last update: 2015-07-14 15:41    [W:0.078 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site