lkml.org 
[lkml]   [2015]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb
From
Date

On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote:

> On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote:
>> On Mon, Jul 06, 2015 at 12:48:56PM -0400, green@linuxhacker.ru wrote:
>>> +static int libcfs_param_debug_mb_set(const char *val,
>>> + const struct kernel_param *kp)
>>> +{
>>> + int rc;
>>> + unsigned num;
>>> +
>>> + rc = kstrtouint(val, 0, &num);
>>> + if (rc == -EINVAL)
>>> + return -EINVAL;
>>
>> Presumably, this is root only so using num uninitialized is not an
>> information leak.
>
> But it's not good, this should be a check for rc < 0 to make sure.
>
> Oleg, can you send a follow-on patch to fix this up?

Sure.
Do you want it now or should I wait till you merge my previous bunch?

Bye,
Oleg


\
 
 \ /
  Last update: 2015-07-14 05:01    [W:0.058 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site