Messages in this thread | | | Date | Tue, 14 Jul 2015 10:56:31 +0900 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH] serial: samsung: Remove redundant DEBUG_LL check |
| |
On 13.07.2015 20:18, Javier Martinez Canillas wrote: > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed > build issues when the driver was built as a module. One of those was > that printascii is only accessible when the driver is built-in. > > But there is no need to check for defined(CONFIG_DEBUG_LL) since the > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > drivers/tty/serial/samsung.c | 1 - > 1 file changed, 1 deletion(-)
Although this redundancy is not harmful the patch seems fine, so: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
| |