lkml.org 
[lkml]   [2015]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 04/12] MIPS/pci-rt3883: Consolidate chained IRQ handler install/remove


On Mon, 13 Jul 2015, Thomas Gleixner wrote:

> Chained irq handlers usually set up handler data as well. We now have
> a function to set both under irq_desc->lock. Replace the two calls
> with one.

Are the original calls remaining? If so, should there be a semantic patch
in the kernel to check for this, in case people ut the two calls in teh
future.

julia

>
> Search and conversion was done with coccinelle.
>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/pci/pci-rt3883.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: tip/arch/mips/pci/pci-rt3883.c
> ===================================================================
> --- tip.orig/arch/mips/pci/pci-rt3883.c
> +++ tip/arch/mips/pci/pci-rt3883.c
> @@ -225,8 +225,7 @@ static int rt3883_pci_irq_init(struct de
> return -ENODEV;
> }
>
> - irq_set_handler_data(irq, rpc);
> - irq_set_chained_handler(irq, rt3883_pci_irq_handler);
> + irq_set_chained_handler_and_data(irq, rt3883_pci_irq_handler, rpc);
>
> return 0;
> }
>
>
>


\
 
 \ /
  Last update: 2015-07-13 23:01    [W:0.105 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site