Messages in this thread | | | Date | Mon, 13 Jul 2015 10:05:45 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs |
| |
On 07/13/2015 09:53 AM, Oleg Nesterov wrote: > On 07/13, Kirill A. Shutemov wrote: >> >> We don't really need ->vm_ops here: MPX VMA can be detected with VM_MPX >> flag. And vma_merge() will not merge MPX VMA with non-MPX VMA, because >> ->vm_flags won't match. > > Agreed. > > I am wondering if something like the patch below (on top of yours) makes > sense... Not sure, but mpx_mmap() doesn't look nice too, and with this > change we can unexport mmap_region().
These both look nice to me (and they both cull specialty MPX code which is excellent). I'll run them through a quick test.
| |