Messages in this thread | | | Date | Mon, 13 Jul 2015 16:42:55 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes |
| |
On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: > On 1 July 2015 at 19:38, Mark Brown <broonie@kernel.org> wrote: > > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote:
> >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > >> + struct list_head *deps) > >> +{ > >> + add_dependency(fwnode, "nvidia,i2s-controller", deps); > >> + add_dependency(fwnode, "nvidia,audio-codec", deps); > >> +}
> > Why is this all being open coded in an individual driver (we already > > know about and manage all these dependencies in the core...)? If we're > > going to do this I'd expect the interface for specifying DT nodes to the > > core to be changed to support this.
> Are you thinking of changing drivers to acquire their resources > through Arnd's devm_probe (only that the resource table would have to > be in struct device_driver)?
> https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel
No, I'm looking at how we already have all the "did all my dependencies appear" logic in the core based on data provided by the drivers. [unhandled content-type:application/pgp-signature] | |