lkml.org 
[lkml]   [2015]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v5 15/19] KVM: eventfd: add irq bypass consumer management
From
Date
 13/07/2015 15:16, Eric Auger wrote:
>> >
>> > + irqfd->consumer.token = (void *)irqfd->eventfd;
>> > + kvm_arch_irq_consumer_init(&irqfd->consumer);
> what if the architecture does not implement kvm_arch_irq_consumer_init?
>
> Also you are using here this single function kvm_arch_irq_consumer_init
> to do some irq bypass manager settings + attaching your
> irqfd->arch_update cb which does not really relate to IRQ bypass
> manager. I think I preferred the approach where start/top/add/del were
> exposed separately ([RFC v2 5/6] KVM: introduce kvm_arch functions for
> IRQ bypass).
>
> Why not adding another kvm_arch_irq_routing_update then, not necessarily
> linked to irq bypass manager.

Yes, I also preferred the dummy kvm_arch_* functions to this approach
with an init function. You'd have to add dummy init functions anyway
for non-ARM, non-x86 architectures.

Paolo


\
 
 \ /
  Last update: 2015-07-13 16:01    [W:0.128 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site