Messages in this thread | | | Date | Mon, 13 Jul 2015 00:25:37 -0400 | From | Peter Hurley <> | Subject | Re: [PATCH 2/7] tty: core: Add tty_debug() for printk(KERN_DEBUG) messages |
| |
On 07/12/2015 11:47 PM, Joe Perches wrote: > On Sun, 2015-07-12 at 22:49 -0400, Peter Hurley wrote: >> Introduce tty_debug() macro to output uniform debug information for >> tty core debug messages (function name and tty name). > [] >> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c > [] >> @@ -768,7 +768,7 @@ static void do_tty_hangup(struct work_struct *work) >> void tty_hangup(struct tty_struct *tty) >> { >> #ifdef TTY_DEBUG_HANGUP >> - printk(KERN_DEBUG "%s hangup...\n", tty_name(tty)); >> + tty_debug(tty, "\n"); > > Why drop the "hangup..." ?
tty_debug() prints the function name; in this case, tty_hangup().
>> diff --git a/include/linux/tty.h b/include/linux/tty.h > [] >> +#define tty_debug(tty, f, args...) \ >> + do { \ >> + printk(KERN_DEBUG "%s: %s: " f, __func__, \ >> + tty_name(tty), ##args); \ >> + } while (0) > > Single statement macros don't need do {} while (0)
Ah, yep. Old hold-over from when tty_name() needed a temp buffer.
> #define fmt, ... > using fmt, ##__VA_ARGS__ > > is more common.
Ok.
Regards, Peter Hurley
| |