Messages in this thread | | | From | Phil Edworthy <> | Subject | RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0 | Date | Mon, 13 Jul 2015 09:04:14 +0000 |
| |
Hi Sergei,
On 10 July 2015 17:36, Sergei wrote: > Hello. > > On 07/07/2015 02:55 PM, Phil Edworthy wrote: > > > Instead of statically selecting the PHY connection to either the > > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > > dts to specifiy gpio pins for the vbus and id signals. Additional > > These GPIOs don't have anything to do with the PHY, they're interfacing > Maxim MAX3355 OTG chip for which I have submitted the extcon driver. Hmm, I see what you mean... could you post your latest version of that driver as it seems to have stalled 6 months ago?
> > gpio pins are used to control power to an external OTG device and > > an override to turn vbus on/off. > > > Note: the R-Car USB PHY only allows this Host/Function switching > > on channel 0. > > > This has been tested on a r8a7791 based Koelsch board, which uses > > a MAX3355 device to supply vbus power when needed. > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > I'm inclined to NAK this. You're modifying the wrong driver, I think. > > WBR, Sergei
Thanks Phil
| |